Move Code Reviewers from Wiki into the book #946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntindle
changed the title
ShadowMitia
reviewed
Nov 28, 2021
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
ShadowMitia
reviewed
Nov 28, 2021
ShadowMitia
reviewed
Nov 28, 2021
ShadowMitia
requested changes
Nov 28, 2021
Co-authored-by: Dimitri Belopopsky <ShadowMitia@users.noreply.github.com>
Co-authored-by: Sammy Plat <amaras@vivaldi.net>
Co-authored-by: Sammy Plat <amaras@vivaldi.net>
ShadowMitia
reviewed
Nov 29, 2021
ShadowMitia
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving code reviewers list from the wiki into the book both makes the list of reviewers more public while also allowing people to add themselves. This will help with reducing the workload of maintainers while also allowing automation later to access the data and automatically assign reviews to those listed by each language when a label is assigned.
Note, due to the oddity with honkit markdown, all usernames must be separated by a character that isn't used in link notation. I've chosen "," (comma) as it is easy to parse and a common list seperator.