Skip to content

Fix warnings on size_t to int conversions on C++ Tree Traversal #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2021
Merged

Fix warnings on size_t to int conversions on C++ Tree Traversal #933

merged 2 commits into from
Dec 1, 2021

Conversation

ShadowMitia
Copy link
Contributor

No description provided.

@Amaras Amaras added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) lang: c++ C++ programming language labels Nov 22, 2021
stormofice
stormofice approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@stormofice stormofice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Looks good to me.
[Tested with g++ -std=c++17 -Wall -Werror, g++ version 9.3.0]

@Amaras
Copy link
Member

Amaras commented Dec 1, 2021

Looks good to me. [Tested with g++ -std=c++17 -Wall -Werror, g++ version 9.3.0]

The objective is to compile with -Wall -Wextra -Werror, so could you please test this?

@stormofice
Copy link
Contributor

Also works with -Wextra.

@Amaras
Copy link
Member

Amaras commented Dec 1, 2021

Perfect, I'll merge this PR then

@Amaras Amaras merged commit cf655b0 into algorithm-archivists:main Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stormofice stormofice stormofice approved these changes

Assignees
No one assigned
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) lang: c++ C++ programming language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShadowMitia @Amaras @stormofice