Skip to content

Remove case sensitive paths #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

hugo-s29
Copy link
Contributor

The files Sobel_filters.png and sobel_filters.png (in contents/convolutions/res) can't coexist on Windows.
I've checked, only sobel_filters.png is used and both images seem to be identical.
So, I've removed the other one.

This issue was discussed in PR #807.

Copy link
Member

@Amaras Amaras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, if you've checked and it's the only thing, then I'm all in on it, and merge as soon as the GH action build finishes.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to be honest, I have no idea where the upper-cased one came from. I never use that convention, so it must have slipped through the cracks. Thanks for the catch and sorry for the troubles!

@leios leios merged commit 41b9e86 into algorithm-archivists:master Aug 24, 2021
@hugo-s29 hugo-s29 deleted the case_sensitive_paths branch August 25, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants