C++ sample code for The Barnsley Fern #835
Conversation
Amaras
added
the
Implementation
|
Thanks for the PR |
| using Row = std::array<double, 3>; | ||
| using Op = std::array<Row, 3>; | ||
|
|
||
| constexpr auto OpN = 4; |
There was a problem hiding this comment.
This should probably be 4U, because of signedness.
There was a problem hiding this comment.
what is your motivation? I do not understand why it should be unsigned?
There was a problem hiding this comment.
Because I get warnings of signed/unsigned comparisons. Sorry I should've been clearer on this...
|
|
||
| constexpr auto OpN = 4; | ||
|
|
||
| template <int N> |
There was a problem hiding this comment.
this should probably be template
There was a problem hiding this comment.
it is a template. What do you mean?
There was a problem hiding this comment.
Wooops, not sure what happened here.
I meant, this should probably be template <unsigned int N>, again because of signed/unsigned comparison warngings
| return x; | ||
| } | ||
|
|
||
| template <int N> |
There was a problem hiding this comment.
same, this should probably be template
| return v; | ||
| } | ||
|
|
||
| template <int N> |
There was a problem hiding this comment.
same, this should probably be template
|
|
||
| auto operator*(const Op& x, const Vec3& y) { | ||
| auto ret = Vec3{}; | ||
| for (auto i = 0; i < 3; ++i) { |
There was a problem hiding this comment.
should probably be auto i = 0U
| auto ret = Vec3{}; | ||
| for (auto i = 0; i < 3; ++i) { | ||
| ret[i] = 0; | ||
| for (auto j = 0; j < 3; ++j) |
There was a problem hiding this comment.
should probably be auto j = 0U
|
Mitia, I pushed fixes. |
There was a problem hiding this comment.
Thanks again for the code and thanks to @ShadowMitia for the review!
The Barnsley Fern with 100000 points
