removing sorting (and searching) chapters #799
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, hear me out:
These chapters are stubs. We all know it. I have been planning on cleaning them up; however, because everyone knows bubble and bogo sort, there have been an insane number of code contributions to these chapters. Most of these are inconsistent and need to be re-worked.
We need to do the following:
is_sorted(...)
function that will work for all sorting methodsThe reason I want to remove them (for now) is that I feel they are providing the wrong perspective of the algorithm archive. There are other stubby chapters (I am looking at you, Gift Wrapping), but they can hide behind anonymity a bit. Sorting and searching are some of the first methods people go to when looking at a book on algorithms, so if we do them... We need to do them right, in my opinion.
Now, people are opening chapter requests for other sorting methods using the bubble and bogo sort chapters as a base... Which is ultimately putting more work on me down the road when I am able to revamp the sorting and searching methods, as now I need to heavily revise those chapters as well.
So, thoughts?
PS: I have all the code already written backed up on another branch. It will all come back later this year.