Skip to content

Update to the convolution chapter(s) #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

leios
Copy link
Member

@leios leios commented Jan 25, 2021

This is a draft for the upcoming convolution chapters. Let me know if there's anything that's unclear to update before merging!

@leios leios added Discussion This is open for a discussion. Chapter This provides a new chapter. (md files are edited) labels Jan 25, 2021
@leios
Copy link
Member Author

leios commented Jan 26, 2021

Some notes on Discord:

  1. We should probably use a different test. No random numbers. Maybe sawtooth with square?
  2. It is a bit weird that the simple boundaries will grab the first part of the full convolution instead of the center of the full convolution. I did this because I thought it was not particularly intuitive to have the filter start while overlapping the signal. I could rewrite the code or add (something like) the following:

What is j doing in this case? Well, it is iterating through elements on the input array that will be multiplied by the signal. Here, we chose for it to count up to i, but depending on the use-case, you might want to center the convolutional kernel. To do this, we would count from i-filter_size/2 to i+filter_size/2

I am just making sure these are written down for later

@leios
Copy link
Member Author

leios commented Mar 4, 2021

Ok, I am happy with this chapter. I'll read it over one more time tomorrow before merging

@leios leios merged commit c98953f into algorithm-archivists:master Mar 4, 2021
@leios leios deleted the conv_update branch March 4, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter This provides a new chapter. (md files are edited) Discussion This is open for a discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant