Added Huffman with Haskell #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strega-nil
suggested changes
Apr 17, 2018
| import qualified Data.Map as M | ||
| import Data.List (insert, sort) | ||
|
|
||
| data Tree a = Nil |
There was a problem hiding this comment.
Does this have to have Nil? It seems better not to support implicitly nullability.
| where toSortedList = sort . map swap . M.toList | ||
| swap (a, i) = (i, a) | ||
|
|
||
| buildTree :: (Ord a) => [a] -> Tree a |
There was a problem hiding this comment.
And then this would just return a Maybe (Tree a)
|
Switched to a Maybe (Tree a) on ubsan's suggestion. |
|
This one also looks good to merge, unless there are outstanding problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Haskell implementation, and fixed a few typos and trailing spaces in huffman.md.
The main issue with the code is that (to simplify implementation) the tree generated can have some branches inverted compared with the algorithm from the video. The bit length doesn't change at all, so it's not a huge deal, maybe.
Thoughts?