Skip to content

Update C# files fit the new CSharp repository. Fix import. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2018
Merged

Update C# files fit the new CSharp repository. Fix import. #74

merged 7 commits into from
Apr 15, 2018

Conversation

june128
Copy link
Member

@june128 june128 commented Apr 7, 2018

new C# AAA repo

Updates the C# files to fit the new C# AAA repo. This repo is a restructured version of the old C# AAA repo.

The most visible changes in the book are shorter and simpler namespaces.
Some comments are removed due to redundancy as well.

All that comes through the new organization of the new C# AAA repo. The repo now isn't one big project for all algorithms anymore, but one project per algorithm.

fix import

Fix import in euclidean.md.

ToDo

  • Should/Can namespace and type have the same name in this case? // in this case I decided to use the same name for type and namespace
  • Should a Program.cs be included? // yes

@june128
Copy link
Member Author

june128 commented Apr 11, 2018

Don't merge, problem may exist.

@june128
Copy link
Member Author

june128 commented Apr 12, 2018

Checked the files by comparing the files:

Seems good, but:
Should Program.cs be included? -> I need to discuss/resolve that.

-> I create ToDo for this PR, to get the tasks tracked.

@leios leios merged commit 3f108a8 into algorithm-archivists:master Apr 15, 2018
@june128 june128 deleted the updateCSharpFilesPR branch May 29, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants