Added Bubblesort in Coconut #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berquist
requested changes
Jul 19, 2020
| for i in range(length): | ||
| for j in range(length - i - 1): | ||
| if array[j] > array[j + 1]: | ||
| array[j], array[j + 1] = array[j + 1], array[j] |
There was a problem hiding this comment.
I would rather see a full FP solution rather than a Python translation, even if it is one of the solutions in https://codereview.stackexchange.com/questions/197868/bubble-sort-in-haskell.
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| array = range(10) |> map$(-> random.randint(0, 1000)) |> list |
There was a problem hiding this comment.
Make sure all the tabs are replaced with spaces and that your editor is set up to use the EditorConfig file.
berquist
added
the
Implementation
|
I was going to quit the functional style, but it seems it works quite well. Maybe not for huge lists, but close enough. |
berquist
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as for Bogosort, I just slightly improved the Python code and removed the
mainfunction.I opened those two PRs mainly to have them in Coconut, after thinking a bit about it.
(Also, I forgot to click the button, so that's why this one arrived late compared to the Bogosort one; I implemented them the same day)