Skip to content

fixing julia function to output pi estimate #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2020
Merged

fixing julia function to output pi estimate #710

merged 1 commit into from
May 24, 2020

Conversation

leios
Copy link
Member

@leios leios commented May 24, 2020

As noted in #696, the Julia implementation needed to be updated to return the pi estimate and not print in the function

@berquist berquist added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label May 24, 2020
berquist
berquist approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working and the book looks right. (Was actually getting a signif not defined on Julia 1.4.1.)

@berquist berquist merged commit 1a34a46 into algorithm-archivists:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berquist berquist berquist approved these changes

Assignees
No one assigned
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leios @berquist