Tree traversal in MATLAB #690
Conversation
berquist
added
the
Implementation
|
Accidentally pushed to the wrong branch, fixing now |
foldsters
force-pushed
the
tree_traversal_in_matlab
branch
from
30b71e1 to
76cf2bb
Compare
|
Okay that should be fixed |
There was a problem hiding this comment.
I've never really been a fan of cell arrays or map containers but here I am. The code is really good, very true to the AAA chapter as well, it goes through all the implementations mentioned in order.
I'd suggest replacing "if length(x)" with "~isempty(x)" which is immeasurably quicker (not that it really matters here). This suggestion also works for the while loops in the stack and queue functions simply: "while ~isempty(x)".
Might also be wise to add an fprintf("\n") after line 148 so that the code exist on a new line rather than the output one.
Otherwise it's great, not commented but the variables and routines are so well labelled I could hardly find a place where comments were necessary to know what was going on.
|
I'm not a fan of cell arrays either, but it seems it's the only way to get type-agnostic tree structures. I'll work on the updates now. |
|
That should be good to go! |
All code sections are included. Accidentally deleted some lines during debugging and added them back in.