Skip to content

[Haskell] Computus #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions contents/computus/code/haskell/gauss_easter.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
data Mode = Servois | Easter

computus :: Mode -> Int -> String
computus mode year =
case mode of
Servois ->
-- Value for Servois' table
show $ (21 + d) `mod` 31
Easter ->
-- Determination of the correct month for Easter
if 22 + d + f > 31
then "April " ++ show (d + f - 9)
else "March " ++ show (22 + d + f)
where
a, b, c, d, e, f, k, m, n, p, q :: Int
-- Year's position on the 19 year metonic cycle
a = year `mod` 19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type signatures are recomended for local bindings. They help you think and avoid crazy type errors on basic mistakes (as ghc will just try make it work somehow).
So consider adding: a :: Int

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that achieve anything? The signature of mod is mod :: Integral a => a -> a -> a and since year is an Int, a cannot possibly be anything else.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make a mistake on writing implementations, having your code blotted with typesignatures will avoid crazy ghc deductions. It's more defensive. Typesignatures rarely do anything in haskell (1). It'sHindley–Milner all the way down.

(1): Bar some major exceptions from langauge extensions, such as datakinds, GADTs etc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it would hinder readability I think. And since all the local bindings derive from year, it would do nothing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind going either way here. It looks like this conversation is the only one holding this PR back.

Copy link

@jappeace jappeace May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the confusion, how about this:

  a :: Int
  a = year `mod` 19

let blocks can have same typesignatures as functions. In fact, you can put functions in let blocks!

Don't worry about being stubborn, this is constructive in my opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this conversation is still going, so let me know when both of you are happy with the code!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this resolved?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, I"m not getting a reply so yes?

Copy link
Member Author

@jiegillet jiegillet Jun 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did reply, on May 24, on another comment. I tried what you suggested (with a twist).
EDIT: nope, that comment was for something else. I pushed a commit but did not comment. Sorry about that.

-- Century index
k = year `div` 100
-- Shift of metonic cycle, add a day offset every 300 years
p = (13 + 8 * k) `div` 25
-- Correction for non-observed leap days
q = k `div` 4
-- Correction to starting point of calculation each century
m = (15 - p + k - q) `mod` 30
-- Number of days from March 21st until the full moon
d = (19 * a + m) `mod` 30
-- Finding the next Sunday
-- Century-based offset in weekly calculation
n = (4 + k - q) `mod` 7
-- Correction for leap days
b = year `mod` 4
c = year `mod` 7
-- Days from d to next Sunday
e = (2 * b + 4 * c + 6 * d + n) `mod` 7
-- Historical corrections for April 26 and 25
f =
if (d == 29 && e == 6) || (d == 28 && e == 6 && a > 10)
then -1
else e

-- Here, we will output the date of the Paschal full moon
-- (using Servois notation), and Easter for 2020-2030
main :: IO ()
main = do
let years :: [Int]
years = [2020 .. 2030]
servoisNumbers, easterDates :: [String]
servoisNumbers = map (computus Servois) years
easterDates = map (computus Easter) years
putStrLn "The following are the dates of the Paschal full moon (using Servois notation) and the date of Easter for 2020-2030 AD:"
putStrLn "Year\tServois number\tEaster"
let conc :: Int -> String -> String -> String
conc y s e = show y ++ "\t" ++ s ++ "\t\t" ++ e
mapM_ putStrLn $ zipWith3 conc years servoisNumbers easterDates
2 changes: 2 additions & 0 deletions contents/computus/computus.md
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,8 @@ For now, we have the code outputting a tuple of $$d$$ and $$e$$, so users can us
{% method %}
{% sample lang="jl" %}
[import, lang:"julia"](code/julia/gauss_easter.jl)
{% sample lang="hs" %}
[import, lang:"haskell"](code/haskell/gauss_easter.hs)
{% sample lang="py" %}
[import, lang:"python"](code/python/gauss_easter.py)
{% sample lang="crystal" %}
Expand Down