Skip to content

Remove redundant jarvis.jl file #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2019
Merged

Remove redundant jarvis.jl file #617

merged 2 commits into from
Jul 6, 2019

Conversation

Antetokounpo
Copy link
Contributor

There were two jarvis.jl files in the jarvis_march directory, this pull request simply removes the redundant file.

@c252 c252 added the Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category. label Jul 1, 2019
dovisutu
dovisutu approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@dovisutu dovisutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked that this redundant file isn't related to anything (at least not in .md).
I approved this, but since I'm not a reviewer with write access, this is only a confirmation.

@leios
Copy link
Member

leios commented Jul 4, 2019

Hey @Antetokounpo, thanks for the change! Since you are a first-time contributor, would you mind putting your name at the bottom of the CONTRIBUTORS.md file? If you would prefer not to do that, it's totally fine!

@Antetokounpo
Copy link
Contributor Author

Yeah sorry, I didn't think I had to since it was a really small contribution. I added it.

c252
c252 approved these changes Jul 6, 2019
View reviewed changes
Copy link
Member

@c252 c252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@c252 c252 merged commit 4793490 into algorithm-archivists:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c252 c252 c252 approved these changes

@dovisutu dovisutu dovisutu approved these changes

Assignees
No one assigned
Labels
Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Antetokounpo @leios @c252 @dovisutu