using isapprox(a,b) function in julia instead of rolling our own #612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leios
changed the title
leios
added
the
Implementation Edit
|
I personally like the Unicode syntax in Julia |
|
I'll be honest, I just don't want to have to change text editors to put in the LaTeX. The unicode-ness of Julia also makes it less readable in my opinion... But I know people who absolutely love unicode |
|
I understand, also with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The julia implementation of fft had an approximate function we created ourselves, but there was no reason to do so when the
isapprox(a,b)function exists