Skip to content

Graham scan implementation in Common Lisp #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 24, 2020

Conversation

Trashtalk217
Copy link
Contributor

I'm on a roll.

Generally happy with this one except the graham-scan function itself. It's not that clean and quite slow; nth and append are somewhat expensive. Otherwise I'm mostly good and I appreciate any review.

I messed up with git so that's why it looks so messy.

@june128 june128 added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Jun 5, 2019
@berquist berquist self-assigned this Oct 6, 2019
@berquist
Copy link
Member

berquist commented Oct 6, 2019

Can you do a rebase on top of current master to fix the conflict?

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, just one comment on the consistency of implementations.

@Trashtalk217
Copy link
Contributor Author

Basically as good as it's going to get. graham-scan Is still destructive because the standard sort is destructive in Common Lisp. But because sort only shuffles things around and the order of these things doesn't matter, I'm sure it won't matter that much. You could always pass a copy of the gift to the function ((copy gift)).

Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry it took so long to get back to you. I think this implementation is really nice. Thanks for all your work!

@berquist berquist merged commit 9315ce9 into algorithm-archivists:master May 24, 2020
@Trashtalk217 Trashtalk217 deleted the graham-scan-lisp branch May 24, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants