-
-
Notifications
You must be signed in to change notification settings - Fork 360
Graham scan implementation in Common Lisp #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graham scan implementation in Common Lisp #605
Conversation
Can you do a rebase on top of current master to fix the conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, just one comment on the consistency of implementations.
Basically as good as it's going to get. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry it took so long to get back to you. I think this implementation is really nice. Thanks for all your work!
I'm on a roll.
Generally happy with this one except the
graham-scan
function itself. It's not that clean and quite slow;nth
andappend
are somewhat expensive. Otherwise I'm mostly good and I appreciate any review.I messed up with git so that's why it looks so messy.