Skip to content

Added Verlet integration in Kotlin #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2018
Merged

Added Verlet integration in Kotlin #535

merged 6 commits into from
Oct 30, 2018

Conversation

sklan
Copy link
Contributor

@sklan sklan commented Oct 25, 2018

No description provided.

@june128 june128 added Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) and removed Hacktoberfest The label for all Hacktoberfest related things! labels Oct 25, 2018
@berquist berquist self-assigned this Oct 27, 2018
berquist
berquist requested changes Oct 28, 2018
View reviewed changes
Copy link
Member

@berquist berquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Really minor stuff.

contents/verlet_integration/code/kotlin/verlet.kt Outdated
println("Time for Verlet integration is: $verletTime")

val stormerVerlet = stormerVerlet(5.0, -10.0, 0.01)
println("Time for Stormer Verlet integration is: " + stormerVerlet.time)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use string interpolation for all 5 print calls.

contents/verlet_integration/code/kotlin/verlet.kt Outdated

val velocityVerlet = velocityVerlet(5.0, -10.0, 0.01)
println("Time for vel Verlet integration is: " + velocityVerlet.time)
println("Velocity for vel Verlet integration is: " + velocityVerlet.vel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the full word "velocity" in both of the above lines?

@berquist
Copy link
Member

Thanks!

@berquist berquist merged commit 4f8728f into algorithm-archivists:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berquist berquist berquist approved these changes

Assignees

@berquist berquist

Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sklan @berquist @june128