modifying C++ energy calculation to match split-op code. #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leios
added
Implementation Edit
zsparal
suggested changes
Oct 23, 2018
| } | ||
|
|
||
| void fft(std::vector<std::complex<double>> x, int n, bool inverse) { | ||
| std::complex<double> y[n]; |
There was a problem hiding this comment.
This is unfortunately not standard C++. The way to solve this issue is:
std::vector<std::complex<double>> y(x.size(), std::complex<double>(0.0, 0.0));This way you don't need either the memset or the push_back loop
berquist
requested changes
Oct 27, 2018
berquist
requested changes
Oct 28, 2018
zsparal
approved these changes
Oct 28, 2018
Co-Authored-By: leios <jrs.schloss@gmail.com>
Co-Authored-By: leios <jrs.schloss@gmail.com>
Co-Authored-By: leios <jrs.schloss@gmail.com>
Co-Authored-By: leios <jrs.schloss@gmail.com>
Co-Authored-By: leios <jrs.schloss@gmail.com>
|
Ok, looking good. |
berquist
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up with #476 . At first glance, it looked fine, but there were obvious updates necessary. This should match #420.
@rajdakin Sorry for prematurely merging.