Added exclamation marks to mutating julia functions #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
Implementation
leios
reviewed
Oct 20, 2018
| @@ -9,15 +9,15 @@ function is_sorted(a::Vector{Float64}) | |||
| return true | |||
| end | |||
|
|
|||
| function bogo_sort(a::Vector{Float64}) | |||
| function bogo_sort!(a::Vector{Float64}) | |||
| while(!is_sorted(a)) | |||
| shuffle!(a) | |||
| end | |||
| end | |||
|
|
|||
| function main() | |||
| a = [1, 3, 2, 4] | |||
There was a problem hiding this comment.
Suggested change
| a = [1, 3, 2, 4] | |
| a = [1.0, 3, 2, 4] |
This is my fault, but there is a type error here where the bogo_sort function wants floats and we are reading in ints. Could we fix this?
Also improved typing of bogo sort.
Vexatos
force-pushed
the
julia-convention-fixes
branch
from
8a22007 to
c5f221c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By convention, Julia functions that mutate one of their parameters need to have an exclamation mark at the end of their name; this fixes all instances of that that I could find.