PHP unify code style #515
Merged
PHP unify code style #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PudottaPommin
added
Implementation Edit
Fixed naming
Butt4cak3
requested changes
Oct 19, 2018
|
|
||
| echo 'DFS Queue:' . PHP_EOL; | ||
| TreeTraversal::dfs_queue($node); | ||
| TreeTraversal::DFSQueue($node); | ||
|
|
||
| // If you want try binary order non-binary tree | ||
| // Comment generation of new tree bellow | ||
| // If you do that, exception will be thrown |
There was a problem hiding this comment.
I'd rephrase this and fix some of the spelling/grammar mistakes to make it more clear what you're trying to say here.
// If you want to try to run binary order on a non-binary tree,
// comment out the generation of the new tree below.
// If you do that, an exception will be thrown.
changed comment
Butt4cak3
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies PHP implementations, which were pushed before defining code style.
Functionality is same, except one less output in TreeTraversal, which was JSON of the tree.