Euler method in js #511
Closed
Euler method in js #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops uh the bash commit is there |
june128
added
Hacktoberfest
|
The reversal of the Bubble Sort Bash commit could cause merge conflicts as soon as #509 is merged. A rebase would've probably been better here. If you want to, I can explain to you how you'd do that on Discord. It's a very powerful tool to have in your repertoire. |
Ariana1729
force-pushed
the
eulerde_js
branch
from
fa97b60 to
057dd6d
Compare
|
Ah ok |
|
oops misspelt XD |
| if (n != 0) { | ||
| result[0] = 1; | ||
| for (let i = 1; i < n; ++i) { | ||
| result[i] = result[i-1] - 3 * result[i-1] * timeStep; |
There was a problem hiding this comment.
result[i-1] should use spaces around - so it looks like result[i - 1]
|
Oh, uhm... We kinda sorta already have a Forward Euler PR for JavaScript in #418. |
|
oh whoops missed that PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+Fixed the ODE(hopefully), cuz there was an inconsistency with ODE and the code