Verlet in X86_64 #505
Merged
Verlet in X86_64 #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
Implementation
zsparal
suggested changes
Oct 12, 2018
| comisd xmm0, xmm7 # Check if position is greater then 0.0 | ||
| ja verlet_loop | ||
| verlet_return: | ||
| movsd QWORD PTR [rdi], xmm3 # Saving time value |
There was a problem hiding this comment.
You should just return in xmm0 and xmm1 (if necessary), passing in the pointer to return floats is a bit weird
| comisd xmm0, xmm7 # Check if position is greater then 0.0 | ||
| ja stormer_verlet_loop | ||
| stormer_verlet_return: | ||
| movsd QWORD PTR [rdi], xmm3 # Saving time and velocity |
There was a problem hiding this comment.
Similarly, return in xmm0 and xmm1
| comisd xmm0, xmm7 | ||
| ja velocity_verlet_loop | ||
| velocity_verlet_return: | ||
| movsd QWORD PTR [rdi], xmm4 # Saving time and velocity |
There was a problem hiding this comment.
Similarly, return in xmm0 and xmm1
|
I would agree with @Gustorn here |
Liikt
approved these changes
Oct 17, 2018
zsparal
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.