Forward euler in x86_64 #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
Implementation
Liikt
requested changes
Oct 14, 2018
| add rsp, 800 # Deallocating array | ||
| pop rbp | ||
| xor rax, rax | ||
| ret |
There was a problem hiding this comment.
Please insert a newline to avoid warnings
Liikt
requested changes
Oct 14, 2018
| if_false: | ||
| add r13, 1 | ||
| loop_check: | ||
| cmp r13, r14 # Check if index is less the array size |
There was a problem hiding this comment.
This whole check doesn't work. You need to change line 69 into add 12, 1 and line 71 into cmp r12, r13 because r13 is your array_size and r12 the loopcounter
Liikt
approved these changes
Oct 15, 2018
|
Well apart from the weird error I still get, this is okay. |
|
I get the newline warning as well. They should be there according to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.