Skip to content

Monte carlo in X86_64 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2018
Merged

Monte carlo in X86_64 #502

merged 3 commits into from
Oct 16, 2018

Conversation

Gathros
Copy link
Contributor

@Gathros Gathros commented Oct 12, 2018

No description provided.

@Gathros Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 12, 2018
Liikt
Liikt previously approved these changes Oct 14, 2018
View reviewed changes
Copy link

@Liikt Liikt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 except the one new line

@Liikt Liikt requested a review from zsparal October 14, 2018 01:52
@Liikt Liikt dismissed their stale review October 14, 2018 02:07

newline is missing at the end of the file resulting in a warning

@Gathros
Copy link
Contributor Author

Gathros commented Oct 14, 2018

I'm not getting warnings.

Liikt
Liikt approved these changes Oct 16, 2018
View reviewed changes
Copy link

@Liikt Liikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Gathros Gathros merged commit 6e9e386 into algorithm-archivists:master Oct 16, 2018
@Gathros Gathros deleted the monte_carlo_asm branch October 20, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liikt Liikt Liikt approved these changes

@zsparal zsparal Awaiting requested review from zsparal

Assignees
No one assigned
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gathros @Liikt