Small change to monte_carlo.c #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
Implementation Edit
Gorzoid
reviewed
Oct 12, 2018
|
|
||
| printf("The estimate of pi is %f\n", estimate); | ||
|
|
||
| printf("The estimate of pi is %g\n", estimate); | ||
| printf("Percentage error: %0.2f%\n", 100 * fabs(M_PI - estimate) / M_PI); |
There was a problem hiding this comment.
I made a mistake here when last fixxing. %\n needs to be %%\n otherwise we get a format warning. Also I am reconsidering limiting the decimal places of the percentage. What do you think
berquist
requested changes
Oct 13, 2018
| bool in_circle(double x, double y, double radius) { | ||
| return x * x + y * y < radius * radius; | ||
| bool in_circle(double x, double y) { | ||
| return x * x + y * y < 1; | ||
| } | ||
|
|
||
| double monte_carlo(int samples) { |
There was a problem hiding this comment.
While we're at it, let's convert everything inside monte_carlo from int to unsigned.
berquist
requested changes
Oct 13, 2018
| } | ||
|
|
||
| double monte_carlo(int samples) { | ||
| double radius = 1.0; | ||
| double monte_carlo(unsigned int samples) { | ||
| int count = 0; |
There was a problem hiding this comment.
This should also be unsigned int.
| } | ||
|
|
||
| double monte_carlo(int samples) { | ||
| double radius = 1.0; | ||
| double monte_carlo(unsigned int samples) { | ||
| int count = 0; | ||
|
|
||
| for (int i = 0; i < samples; ++i) { |
There was a problem hiding this comment.
This should also be unsigned int.
|
It looks like this code is fine? Is there anything left to be done here @berquist ? |
|
I am happy. |
berquist
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.