Skip to content

Added EditorConfig for PHP from Symfony coding standard #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2018
Merged

Added EditorConfig for PHP from Symfony coding standard #442

merged 1 commit into from
Oct 4, 2018

Conversation

PudottaPommin
Copy link
Member

This is best to merge before other PHP PRs, so I can update code with this code style

@PudottaPommin PudottaPommin mentioned this pull request Oct 4, 2018
Merged
@Gathros Gathros added the General label Oct 4, 2018
@Gathros
Copy link
Contributor

Gathros commented Oct 4, 2018

There you go.

@Gathros Gathros merged commit 1be7b21 into algorithm-archivists:master Oct 4, 2018
@PudottaPommin
Copy link
Member Author

Thanks! :)

@PudottaPommin PudottaPommin deleted the php_add_editorconfig branch October 4, 2018 10:03
@Butt4cak3
Copy link
Contributor

You broke the alphabetical order in .editorconfig ;-(

@PudottaPommin
Copy link
Member Author

O.o there was order? :(
Wanna fix me that? 😈

@Butt4cak3
Copy link
Contributor

Yeah, there was order, but @julianschacher already broke it with his darn [.emojic] section. I'll just fix it whenever I touch the file anyway.

@june128
Copy link
Member

june128 commented Oct 5, 2018

Ohh there was an order; missed that, sorry!

@PudottaPommin
Copy link
Member Author

PHP style guide:

  • PSR-2 standard
  • global functions (set outside of classes) will be snake_case
  • variables will be camelCase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gathros Gathros Gathros approved these changes

Assignees
No one assigned
Labels
General
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PudottaPommin @Gathros @Butt4cak3 @june128