Skip to content

Markdown formatting updates #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2018
Merged

Markdown formatting updates #440

merged 3 commits into from
Oct 4, 2018

Conversation

berquist
Copy link
Member

@berquist berquist commented Oct 4, 2018

  • Use a normal list in CONTRIBUTING, rather than HTML
  • Update license copyright year
  • Unfill text that doesn't change presentation

@leios
Copy link
Member

leios commented Oct 4, 2018

These are all good changes. I cannot remember the purpose of the <br> tags, though...

@leios leios merged commit b543263 into algorithm-archivists:master Oct 4, 2018
@jiegillet
Copy link
Member

Without the <br> all names were on the same line.

@leios
Copy link
Member

leios commented Oct 4, 2018

Ah. Alright. I prematurely merged here then. Been a while since that happened.

So, we can just put a newline between each one instead of the <br> right?

@jiegillet
Copy link
Member

No no, it should be good now, the PR replaced the <br> with - which should create a markdown list. It's an improvement!

@leios
Copy link
Member

leios commented Oct 4, 2018

Ah, I should have checked this in remarkable before merging to be sure. Didn't think about it. Nice.

@jiegillet
Copy link
Member

You can check in GitHub directly, within the PR, just click on view. Once it's merged in, you can just click on the file.

@june128 june128 added Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category. Hacktoberfest The label for all Hacktoberfest related things! and removed Hacktoberfest The label for all Hacktoberfest related things! labels Oct 5, 2018
@berquist berquist deleted the md-formatting branch October 5, 2018 23:55
kenpower pushed a commit to kenpower/algorithm-archive that referenced this pull request Oct 22, 2018
@berquist
Markdown formatting updates (algorithm-archivists#440)
b4f8d23 
* Use a Markdown list rather than HTML breaks

* Update copyright year

* Un-fill text in CONTRIBUTING
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leios leios leios approved these changes

Assignees
No one assigned
Labels
Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@berquist @leios @jiegillet @june128