add thomas alg in C++ #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
requested changes
Oct 4, 2018
| #include <vector> | ||
| #include <cstring> | ||
|
|
||
| void thomas(std::vector<double> const a, std::vector<double> const b, std::vector<double> const c, std::vector<double>& x, const size_t size) { |
There was a problem hiding this comment.
You don't need size when you have a.size().
There was a problem hiding this comment.
yeah that's true, i'll change it
|
|
||
| void thomas(std::vector<double> const a, std::vector<double> const b, std::vector<double> const c, std::vector<double>& x, const size_t size) { | ||
|
|
||
| std::vector<double> y(size); |
There was a problem hiding this comment.
Why not have a normal array since you know it's size is fixed?
There was a problem hiding this comment.
trying to use C++ whenever possible so that it's cohesive, but i'll change it, no problem
Gathros
added
Implementation
|
Looks good to me. I'll let @Gathros finish the review. I just wanted to say, "Thanks for the submission!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.