Making the Ruby bogosort more idiomatic #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2018 14:41
is that even a word?
I don't think that's a real word, either
nic-hartley
changed the title
nic-hartley
changed the title
Gathros
added
Implementation Edit
jiegillet
approved these changes
Oct 4, 2018
kenpower
pushed a commit
to kenpower/algorithm-archive
that referenced
this pull request
Oct 22, 2018
* Idiomatized is that even a word? * More idiomaticity I don't think that's a real word, either * Update bogo_sort.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...mostly by taking full advantage of builtins
I'm not quite sure how implementation edits work -- there are a few Ruby implementations I want to make more idiomatic; should I put them all in one PR or do one PR per algorithm?