Skip to content

Add Bogosort in Factor #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2018
Merged

Add Bogosort in Factor #426

merged 7 commits into from
Oct 8, 2018

Conversation

nic-hartley
Copy link
Contributor

added my username to CONTRIBUTORS.md too

@nic-hartley nic-hartley changed the title Add Bogosort in Factor Add Bogosort in Factor [WIP] Oct 3, 2018
@nic-hartley
Copy link
Contributor Author

nic-hartley commented Oct 3, 2018 •
edited
Loading

whoops, found a bug, fixing now

EDIT: Fixed

@nic-hartley nic-hartley changed the title Add Bogosort in Factor [WIP] Add Bogosort in Factor Oct 3, 2018
@Gathros Gathros added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 3, 2018
@jiegillet jiegillet mentioned this pull request Oct 3, 2018
Merged
jiegillet
jiegillet requested changes Oct 6, 2018
View reviewed changes
Copy link
Member

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, very clear concise (the comment about clump helped).
Could you add one line where you actually use the method?

book.json Outdated
}
},
{
"lang": "factor",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#425 has this change already, you don't need it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#425 also hasn't been merged yet :)

CONTRIBUTORS.md Outdated
<br>
nic-hartley
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting of that file has changed. Use the most recent version from master and add your name to it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@jiegillet jiegillet self-assigned this Oct 6, 2018
@jiegillet
Copy link
Member

Add one main-ish line where you test the function on some array and we're off to merging.

@jiegillet jiegillet merged commit 1ffa3b8 into algorithm-archivists:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees

@jiegillet jiegillet

Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nic-hartley @jiegillet @Gathros