Skip to content

Bogosort fortran #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Oct 4, 2018
Merged

Conversation

depate
Copy link
Contributor

@depate depate commented Oct 2, 2018

Hey all!

Compiled errorless with gcc version 8.2.1 via gfortran -Og -Wall -Werror -o bogosort bogo.f90.

Bogo sort was quite more difficult to implement than bubblesort :D

Regards

depate

@june128 june128 added Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) labels Oct 2, 2018
Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few quick comments about capitalization and implicit non statements

@@ -0,0 +1,48 @@
program bogo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like all other implementations use all caps for program and contains statements. I don't mind either way, as long as it's cosistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, all other implementations are in caps.
My editor only supports syntax prediction in small case. So I used it this time for the sake of speed.

Fortran reference again is not strict about it. I learned at university to be consistent inside a programm.
I can change the case sensitivity, but maybe if a Fortran chapter is ready to publish it should be stated that Fortran does not mind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Fortran chapter is not ready. I was basically just asking to be consistent with the rest of the code. I know Fortran doesn't care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll change it then :)

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capitalizing. We are using FORTRAN. It makes sense to shout.

@leios leios merged commit 4bb9d0b into algorithm-archivists:master Oct 4, 2018
kenpower pushed a commit to kenpower/algorithm-archive that referenced this pull request Oct 22, 2018
* Delete monte_carlo_pi.f90

* init

* further implementation

* next

* hopefully fixes things

* initial commit

* final implementation and documentation

* capitalising the syntax
@depate depate deleted the bogosort_fortran branch October 7, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants