Bogosort in lua #413
Merged
Bogosort in lua #413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leios
added
Implementation
jiegillet
requested changes
Oct 2, 2018
contents/bogo_sort/bogo_sort.md
Outdated
| @@ -31,6 +31,8 @@ In code, it looks something like this: | |||
| [import:17-20, lang:"haskell"](code/haskell/bogoSort.hs) | |||
| {% sample lang="m" %} | |||
| [import:21-28, lang:"matlab"](code/matlab/bogosort.m) | |||
| {% sample lang="lua" %} | |||
| [import:1-29, lang="lua"](code/lua/bogosort.lua) | |||
There was a problem hiding this comment.
This import is for the bogosort function only, you can import the whole file in the Example Code section below
| @@ -0,0 +1,29 @@ | |||
|
|
|||
| @@ -0,0 +1,29 @@ | |||
|
|
|||
| local function shuffle(arr) | |||
| for i = 1, #arr do | |||
There was a problem hiding this comment.
I think i = 1, #arr-1 is enough
|
|
||
| local function shuffle(arr) | ||
| for i = 1, #arr do | ||
| local rand = math.random(#arr) |
There was a problem hiding this comment.
Assuming you are implementing the Fisher–Yates shuffle, you should only pick numbers that are between i and #arr included.
| end | ||
| end | ||
|
|
||
| local arr = {1, 45, 756, 4569, 56, 3, 8, 5, -10, -4} |
There was a problem hiding this comment.
Does it ever finish with 10 elements? :)
There was a problem hiding this comment.
Do not underestimate the speed of lua, only takes 5 seconds on my slow laptop.
|
|
||
| bogosort(arr) | ||
|
|
||
| print(("Sorted array: {%s}"):format(table.concat(arr,", "))) |
bogo_sort.md corrected, properly implemented Fisher–Yates shuffle
|
Think I addressed all the problems listed. |
jiegillet
requested changes
Oct 3, 2018
contents/bogo_sort/bogo_sort.md
Outdated
| @@ -73,6 +75,8 @@ We are done here! | |||
| [import, lang:"haskell"](code/haskell/bogoSort.hs) | |||
| {% sample lang="m" %} | |||
| [import, lang:"matlab"](code/matlab/bogosort.m) | |||
| {% sample lang="lua" %} | |||
| [import:1-29, lang="lua"](code/lua/bogosort.lua) | |||
There was a problem hiding this comment.
Here again, you don't need to write lines explicitly to import the whole file.
Line numbers not needed when importing entire file
jiegillet
approved these changes
Oct 3, 2018
kenpower
pushed a commit
to kenpower/algorithm-archive
that referenced
this pull request
Oct 22, 2018
* Added Bogosort * Fixed code Wasn't running * Added tests Same as bubble sort. * Adding entry to bogo_sort.md * Addressing changes bogo_sort.md corrected, properly implemented Fisher–Yates shuffle * Remove unnecessary line specification Line numbers not needed when importing entire file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if I need to add labels myself. Here's bogosort anyway.