Bubble sort lua #412
Merged
Bubble sort lua #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stole numbers from C code /:
leios
added
Implementation
Pretty sure I got it right, should probably run the book to check
Forgot lua could do this derp.
jiegillet
requested changes
Oct 2, 2018
contents/bubble_sort/bubble_sort.md
Outdated
| @@ -22,6 +22,8 @@ This means that we need to go through the vector $$\mathcal{O}(n^2)$$ times with | |||
| [import:4-9, lang:"python"](code/python/bubblesort.py) | |||
| {% sample lang="m" %} | |||
| [import:1-13, lang:"matlab"](code/matlab/bubblesort.m) | |||
| {% sample lang="lua" %} | |||
| [import:1-19, lang="lua"](code/lua/bubble_sort.lua) | |||
There was a problem hiding this comment.
Here import only the function, and later import the whole file
| @@ -0,0 +1,17 @@ | |||
|
|
|||
| function bubble_sort(arr) | |||
| for i = 1,#arr do | |||
There was a problem hiding this comment.
This only need to be 1,#arr-1 since for n elements you only need to do n-1 passes.
|
|
||
| bubble_sort(arr) | ||
|
|
||
| print(("Sorted array: {%s}"):format(table.concat(arr,", "))) |
There was a problem hiding this comment.
I think you need a newline after the last line
jiegillet
reviewed
Oct 2, 2018
| @@ -0,0 +1,17 @@ | |||
|
|
|||
Fixed bubble_sort.md and small changes to code
jiegillet
requested changes
Oct 3, 2018
contents/bubble_sort/bubble_sort.md
Outdated
| @@ -77,6 +79,8 @@ Trust me, there are plenty of more complicated algorithms that do precisely the | |||
| [import, lang:"python"](code/python/bubblesort.py) | |||
| {% sample lang="m" %} | |||
| [import, lang:"matlab"](code/matlab/bubblesort.m) | |||
| {% sample lang="lua" %} | |||
| [import:1-17, lang="lua"](code/lua/bubble_sort.lua) | |||
There was a problem hiding this comment.
You can simply write [import, lang=...] is you want to import the whole file.
Not necessary when importing entire file
Probably should have tested before pushing
|
Issue was with swap code in the wrong order, checked it and it ran fine this time |
|
"Probably should have tested before pushing" hahaha, yup :) |
jiegillet
approved these changes
Oct 3, 2018
kenpower
pushed a commit
to kenpower/algorithm-archive
that referenced
this pull request
Oct 22, 2018
* Added Bubble Sort in Lua * Added test case Stole numbers from C code /: * Moved files cus derp * Added Lua entry to md file Pretty sure I got it right, should probably run the book to check * Use tuple style swap Forgot lua could do this derp. * Addressing problems Fixed bubble_sort.md and small changes to code * Removed unnecessary line specification Not necessary when importing entire file * Swap code broken Probably should have tested before pushing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lua is pretty empty so I will probably start filling it up for hacktoberfest