Skip to content

Euler fortran #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Oct 3, 2018
Merged

Euler fortran #411

merged 15 commits into from
Oct 3, 2018

Conversation

depate
Copy link
Contributor

@depate depate commented Oct 1, 2018

Hey all!

Another Fortran implementation done.
Compiled without erros with gcc-Version 8.2.1 20180831 (GCC) using gfortran -Og -Wall -Werror -std=f95 -fimplicit-none euler.f90 -o euler.

Something odd with my git again. The merge history is shown. Any idea how to resolve this even though it does not collide with AAA's master branch?

Regards

depate

@leios leios added Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! labels Oct 1, 2018
@berquist
Copy link
Member

berquist commented Oct 2, 2018

This is how I would do it, assuming that you have upstream set to this repo:

git fetch --all
git checkout euler_fortran
git rebase -i upstream/master

This allows you to do an interactive rebase of your branch on top of the current master, so you can change anything in your history. The option I would take is to rewrite the commit message of the first commit to make sense, then "fixup" all other later commits into that one. It squashes everything but discards commit messages.

Compare this to when we hit "Squash and merge" on GitHub, which will pack everything into a single commit just fine, but keep all the nonsense commit messages.

@leios
Copy link
Member

leios commented Oct 3, 2018

I think this is a good PR. Quick question about the CONTAINS statement. Can that be used to clean up the interfaces in previous implementations?

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fortran implementation. I am happy with it.

@leios leios merged commit e347d67 into algorithm-archivists:master Oct 3, 2018
kenpower pushed a commit to kenpower/algorithm-archive that referenced this pull request Oct 22, 2018
* Delete monte_carlo_pi.f90

* init

* further implementation

* next

* forward euler implementation

* revoked merge changed from bubble.f90

* Gitbook documentation

* fix fortran highlight
@depate depate deleted the euler_fortran branch October 7, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants