Skip to content

Added/fixed the C and C++ langs on the split operator method #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

rajdakin
Copy link
Contributor

@rajdakin rajdakin commented Oct 1, 2018

This pull request fixes the split operator method in C (as every code blocks were one line off), and adds the C++ implementation of that split operator method.

@june128 june128 added Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) and removed Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) labels Oct 1, 2018
@Gathros Gathros added the Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category. label Oct 2, 2018
@Gathros
Copy link
Contributor

Gathros commented Oct 2, 2018

This should be two different pull requests not one.

@leios
Copy link
Member

leios commented Oct 2, 2018

This is actually just C++ code, so we should just modify the title to be exclusively C++, not C/C++

Still, we appreciate the submission!

@Gathros
Copy link
Contributor

Gathros commented Oct 2, 2018

@leios No, there are also changes to the markdown that change the way c code is displayed.

@leios
Copy link
Member

leios commented Oct 2, 2018

Oh, I see. Yeah, the line number changes should be a separate PR

@rajdakin
Copy link
Contributor Author

rajdakin commented Oct 2, 2018

Creating two other pull requests, one for each change.

@rajdakin rajdakin closed this Oct 2, 2018
berquist pushed a commit that referenced this pull request Oct 22, 2018
This pull request is one of the two new pull requests requested in #409 and is made to integrate the C++ lang with the split operator method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest The label for all Hacktoberfest related things! Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants