Java version of the forward euler algorithm #400
Conversation
june128
added
Implementation
|
Hey, we appreciate the submission, but are somehow missing expertise in Java. I'll get to this soon, but I was waiting to see if anyone who knew Java more than I do wanted to review it first. |
| int n = 100; | ||
| double dt = 0.01; | ||
| double initial = 1; | ||
| double threshold = 0.01; |
There was a problem hiding this comment.
Make the n, dt, initial and threshold variables to be members of the class, that way they are accesible by all methods of the class and you don't need to pass them around as arguments, thus more readable code
There was a problem hiding this comment.
Thanks for the review! Really appreciate it!
|
I just saw that there is an older PR about this same algorithm which I also reviewed, please check that no one worked on the algorithm you are implementing |
|
Hey, I apologize for the inconvenience here, we just realized there was / is an earlier PR #387 that does this implementation. We usually go on a first-come, first-serve basis here, but I'll keep this PR up in the case that the other PR creator doesn't respond. |
|
Ok, I made the changes Yordrar suggested. Sorry that it's a duplicate. I'll triple check next time. |
|
I close it for now. If #387 doesn't get merged or fails somehow, we can reopen this PR here again. |
This is just a simple version of the algorithm in java. In the text it mentioned using the equation y'=5y, but all the other examples use y'=y-3y and it works out better that way so I used that equation. Also, this is my first attempt at a contribution, so if I'm doing anything wrong or could even just do something better, please let me know.