Skip to content

Adding Euclidean Algorithms in X86-64 Assembly #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 16, 2018
Merged

Adding Euclidean Algorithms in X86-64 Assembly #367

merged 12 commits into from
Oct 16, 2018

Conversation

Gathros
Copy link
Contributor

@Gathros Gathros commented Sep 6, 2018

No description provided.

@Gathros Gathros added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Sep 6, 2018
@leios
Copy link
Member

leios commented Sep 21, 2018

Hey @Gathros I know you are aware of this, but we are currently lacking the ability to adequately review this code because no one really knows assembly here. Sorry about that. This goes for #368 as well.

Liikt
Liikt requested changes Sep 27, 2018
View reviewed changes
Copy link

@Liikt Liikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that what we discuss in #368 applies to here as well.

@Gathros Gathros changed the title Adding Euclidean Algorithms in X86 Assembly WIP Adding Euclidean Algorithms in X86-64 Assembly Oct 1, 2018
@Gathros Gathros changed the title WIP Adding Euclidean Algorithms in X86-64 Assembly Adding Euclidean Algorithms in X86-64 Assembly Oct 1, 2018
@Liikt
Copy link

Liikt commented Oct 16, 2018

Looks good to me now

@Gathros Gathros merged commit b5bc757 into algorithm-archivists:master Oct 16, 2018
@Gathros Gathros deleted the euclid_asm branch October 20, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liikt Liikt Liikt approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gathros @leios @Liikt