Skip to content

Implement monte carlo in ruby #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 2, 2018
Merged

Implement monte carlo in ruby #361

merged 3 commits into from
Sep 2, 2018

Conversation

jasmaa
Copy link
Contributor

@jasmaa jasmaa commented Aug 26, 2018

No description provided.

@june128 june128 added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Aug 26, 2018
jiegillet
jiegillet requested changes Aug 27, 2018
View reviewed changes
Copy link
Member

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just a few details to change.

contents/monte_carlo_integration/code/ruby/monte_carlo.rb Outdated

# Main
pi_estimate = monte_carlo(100000)
percent_error = 100 * (pi_estimate - Math::PI).abs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to divide by Math::PI

contents/monte_carlo_integration/code/ruby/monte_carlo.rb Outdated
percent_error = 100 * (pi_estimate - Math::PI).abs

puts "The estimate of pi is: #{pi_estimate.round(3)}"
puts "The percent error is: #{percent_error.round(3)}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with a newline

@jiegillet jiegillet self-assigned this Aug 27, 2018
jiegillet
jiegillet approved these changes Sep 2, 2018
View reviewed changes
Copy link
Member

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you :)

@jiegillet jiegillet merged commit 0ee2f8e into algorithm-archivists:master Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiegillet jiegillet jiegillet approved these changes

Assignees

@jiegillet jiegillet

Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasmaa @jiegillet @june128