Implement Java version of the stable marriage problem. #345
Conversation
Gathros
added
the
Implementation
| * lists of men and women. | ||
| */ | ||
| public static void findStableMarriages(List<Woman> women, List<Man> men) { | ||
| boolean keep_going; |
There was a problem hiding this comment.
Going by the Java style guide this should be keepGoing
| // Repeat the process if someone is left without a partner. | ||
| keep_going = false; | ||
| for (Person person : leastCommonGender) { | ||
| if (keep_going |= person.isLonely()) { |
There was a problem hiding this comment.
I really don't like this. First, it uses the less common variant of the OR operator (non short-circuiting). Second, it checks the result of an assignemnt which is probably even worse. You could do this instead:
keepGoing = leastCommonGender.stream().anyMatch(Person::isLonely)Or alternatively, get rid of keepGoing altogether:
if (!leastCommonGender.anyMatch(Person::isLonely)) {
break;
}There was a problem hiding this comment.
I very much agree, that is much cleaner!
|
|
||
| public static void main(String[] args) { | ||
| int nPairs = 5; | ||
| List<Woman> women = new LinkedList<>(); |
There was a problem hiding this comment.
You should really use ArrayList in both of these cases. LinkedList is just a bad data structure in general
There was a problem hiding this comment.
The reasoning was that removal from the front of the list would be efficient. But I agree, ArrayList is probably at least just as good.
| class Person { | ||
| private final String name; | ||
| protected Person mate; | ||
| protected List<Person> preferedMates; |
|
|
||
| public void receiveOptions(List<? extends Person> mates) { | ||
| // Preferences are subjective. | ||
| preferedMates = new LinkedList<>(mates); |
There was a problem hiding this comment.
Similarly, use an ArrayList here
| } | ||
|
|
||
| class Woman extends Person { | ||
| private List<Man> suitors = new LinkedList<>(); |
|
@Gustorn Have you had time to look over the changes? Just realized this has been sitting untouched for some weeks now. |
|
I reviewed the changes you made and found everything like @Gustorn requested it. I also went ahead and checked that everything displays properly on the website. I'll go ahead and merge this. |
Butt4cak3
dismissed
zsparal’s stale review
It's 24 days old and everything has been changed as requested
No description provided.