Implement C++ version of Monte Carlo integration #342
Conversation
Gathros
added
the
Implementation
| ++count; | ||
| } | ||
|
|
||
| return 4.0 * count / (double) samples; |
| std::cout << "Enter samples to use: "; | ||
| std::cin >> samples; | ||
|
|
||
| double pi = monte_carlo_pi(samples); |
There was a problem hiding this comment.
Could you name this something else? The difference between lowercase and uppercase pi isn't enough to differentiate where they come from.
| std::cin >> samples; | ||
|
|
||
| double pi = monte_carlo_pi(samples); | ||
| printf("Pi = %f\n", pi); |
There was a problem hiding this comment.
Can you use std::cout here and the next line?
| */ | ||
| double monte_carlo_pi(unsigned samples) { | ||
| static std::default_random_engine generator; | ||
| static std::uniform_real_distribution<double> dist(-1, 1); |
There was a problem hiding this comment.
All the other implementation use a distribution should be between 0 and 1 since we are only looking into a corner. It doesn't fundamentally change anything since you only ever consider x*x anyway, but it would be more consistent with the chapter.
| double x = dist(generator); | ||
| double y = dist(generator); | ||
|
|
||
| if (x*x + y*y < 1) |
There was a problem hiding this comment.
Wait, I just realized you are not using the in_circle function. That defeats the purpose of defining it :)
There was a problem hiding this comment.
Your right! My bad, fixed this now!
I just came across this project and wanted to chip in something. Hope this conforms to any style preferences. 👍