Skip to content

Added Bubble Sort in Crystal #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 2, 2018
Merged

Added Bubble Sort in Crystal #319

merged 4 commits into from
Aug 2, 2018

Conversation

NIFR91
Copy link
Contributor

@NIFR91 NIFR91 commented Aug 1, 2018

Bubble sort in Crystal-lang

@june128 june128 added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Aug 1, 2018
@jiegillet
Copy link
Member

jiegillet commented Aug 1, 2018 •
edited
Loading

Welcome to the AAA @NIFR91, we appreciate your contribution!
Looks nice, I don't know Crystal, but reading the Wikipedia article makes me happy, Ruby syntax and type safety are great features.
The code looks good to me, there is just one thing I'll ask you to do, since this is the first contribution in the Crystal language, you should add it to book.json in the root of the repo. If you need more details, check out this wiki page, it's very detailed.
I also noticed that you sent a PR through your master branch, which has a tendency to get messy if the PR takes some time. We recommend creating branches. More details on the same link as above. (Don't worry about it for this time, though)

PudottaPommin
PudottaPommin reviewed Aug 1, 2018
View reviewed changes
contents/bubble_sort/code/crystal/bubble.cr Outdated
@@ -0,0 +1,22 @@
#!/usr/bin/env crystal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe would be better to leave this line out?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I aggre, I checked the implementation in ruby and i saw it had it too. Crystal called this way makes an automatic fast compilation and execute it. I think it is better to remove it.

@NIFR91
Copy link
Contributor Author

NIFR91 commented Aug 1, 2018

@jiegillet Thanks, I really like the idea of AAA, I just added the language to the book.json. Sorry i missed the wikipage, next time ill make sure to follow all the steps in the guide.

PudottaPommin
PudottaPommin approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@PudottaPommin PudottaPommin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it looks great. Good job :)

jiegillet
jiegillet approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No apology necessary, you did great! Thank you for your contribution, I'm looking forward to see other algorithms in Crystal.

@jiegillet jiegillet merged commit 7bc2b14 into algorithm-archivists:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PudottaPommin PudottaPommin PudottaPommin approved these changes

@jiegillet jiegillet jiegillet approved these changes

Assignees
No one assigned
Labels
Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NIFR91 @jiegillet @PudottaPommin @june128