Skip to content

Added mathjax reference on algorithm-archivists/plugin-mathjax #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Added mathjax reference on algorithm-archivists/plugin-mathjax #312

merged 1 commit into from
Aug 4, 2018

Conversation

PudottaPommin
Copy link
Member

@PudottaPommin PudottaPommin commented Jul 28, 2018

This is applicable if

I set version which is currently as fallback 2.6.1 but it's possible use any version, just changing book.json for future :)

@leios
Copy link
Member

leios commented Aug 3, 2018

Alright, the PR has been merged. What do you mean with the second box, "Reverified correct updating from Github repository"?

@PudottaPommin
Copy link
Member Author

It was just someone else roo test locally if the plugin is correctly downloading from master branch after PR in his repo.

Copy link
Member

@june128 june128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it yesterday and it worked fine, so I'll go ahead and approve this one. Thank you very much @MichalHanajik !

@june128 june128 merged commit 3d29292 into algorithm-archivists:master Aug 4, 2018
@PudottaPommin PudottaPommin deleted the update_mathjax_cdn_plugin branch October 3, 2018 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants