fix grammar #302

Mukundan314 · 2018-07-27T04:35:06Z

No description provided.

leios

Most of these changes are personal preference, and some changes must be addressed for all the changes to be technically correct.

Also: Why did you close the previous PR? If you just pushed changes to that branch, the changes will automatically appear here.

leios · 2018-07-27T04:38:43Z

contents/git_and_version_control/git_and_version_control.md

@@ -51,7 +51,7 @@ git config --global user.email name@email.com
 Obviously, use your own name and e-mail... unless your name is actually *name* and your e-mail is actually *name@email.com*, in which case the above commands are correct.
 In the rare case that a user named "name" with the e-mail "name@email.com" is reading this, I apologize for spoiling your anonymity.
 For everyone else, remember that git is meant to facilitate collaborative code development, so we need to know who is submitting code so we can communicate more effectively later.
-That said, it is alright to use a username and e-mail address that does not spoil your identity in the real world, so long as you are reachable by the information provided.
+That said, it is alright to use an username and e-mail address that does not spoil your identity in the real world, so long as you are reachable by the information provided.


It should be "a" not "an"

leios · 2018-07-27T04:38:53Z

contents/git_and_version_control/git_and_version_control.md

@@ -73,7 +73,7 @@ Regardless, as long as there is a repository under your username on github, we c
    <img  class="center" src="res/clone.png" />
 </p>

-Note that there are 2 provided urls here, one for *ssh* and another for *https*. From the user's perspective, the difference between the two is minimal: ssh requires the user to type only a password when interacting with the remote github repository, while https requires both a username and password.
+Note that there are 2 provided urls here, one for *ssh* and another for *https*. From the user's perspective, the difference between the two is minimal: ssh requires the user to type only a password when interacting with the remote github repository, while https requires both an username and password.


Again, "a" not "an"

leios · 2018-07-27T04:39:28Z

contents/multiplication/multiplication.md

@@ -7,7 +7,7 @@ In some sense, this is what I love about computer science research!
 It takes operations that everyone knows and loves, abstracts them, and transforms them into fast and efficient methods for the computer to implement.
 Sometimes these algorithms are completely baffling.
 I remember laughing for ten minutes after I heard that fft convolutions could be used to calculate a simple integer multiplicationing the Schönhage–Strassen algorithm.
-I thought, "Why would you ever want to use an fft to do something to trivial? This has to be a joke!"
+I thought, "Why would you ever want to use a fft to do something to trivial? This has to be a joke!"


"an" instead of "a"

I changed it to "an FFT(Fast Fourier Transform)"

leios · 2018-07-27T04:41:56Z

contents/cooley_tukey/cooley_tukey.md

@@ -129,7 +129,7 @@ In the end, the code looks like:
 {% endmethod %}

 As a side note, we are enforcing that the array must be a power of 2 for the operation to work.
-This is a limitation of the fact that we are using recursion and dividing the array in 2 every time; however, if your array is not a power of 2, you can simply pad the leftover space with 0's until your array is a power of 2.
+This is a limitation of the fact that we are using recursion and dividing the array into 2 every time; however, if your array is not a power of 2, you can simply pad the leftover space with 0's until your array is a power of 2.


Technically "in" is more correct here. We could say that we divide the array "into 2 equally sized sub-arrays" or something, but "into" requires the objects you are splitting the array into.

Changes it back to "in"

leios · 2018-07-27T04:45:28Z

contents/gaussian_elimination/gaussian_elimination.md

-3. You can add any row to a multiple of any other row
+1. swap any two rows
+2. multiply any row by a non-zero scale value
+3. add any row to a multiple of any other row


We are both technically incorrect here. I should have ended each of my sentences; however, with this new structure, the list is a long run-on sentence. We can change the above sentence to:

"In the end, reducing large systems of equations boils down to a game you play on a seemingly random matrix with 3 possible moves. You can:"

Then the sentence would make sense.

leios · 2018-07-27T04:48:43Z

contents/git_and_version_control/git_and_version_control.md

@@ -139,7 +139,7 @@ git status
 ```

 This will show that `CONTRIBUTORS.md` has been modified.
-If we want to save our changes, we need to add all of the files with changes to them to a package called a `commit`.
+If we want to save our changes, we need to add all the files with changes to them to a package called a `commit`.


This is kinda personal preference, but I like the "of" in there.

leios · 2018-07-27T04:48:58Z

contents/git_and_version_control/git_and_version_control.md

@@ -214,7 +214,7 @@ To switch branches, use
 git checkout branch
 ```

-And this will change all of the files on your local directory to match the branch you have swapped to.
+And this will change all the files on your local directory to match the branch you have swapped to.


Again personal preference, but the "of" just sounds clearer to me.

june128 · 2018-09-12T22:31:43Z

@leios How is the status of this PR? Are you happy with the updated changes?

leios · 2018-09-12T23:41:35Z

No, there are still a few things that need to be addressed.

june128 · 2018-09-14T19:43:09Z

@leios by them or by you?

leios · 2018-09-14T23:04:04Z

By them

june128 · 2018-09-14T23:49:37Z

Ok. Do you still plan to work on this PR @Mukundan314 ?

Mukundan314 · 2018-09-15T11:57:45Z

Ok. Do you still plan to work on this PR @Mukundan314 ?

No

leios · 2018-09-15T22:33:09Z

Oh, shoot. Sorry @Mukundan314 I didn't realize you had addressed the problems. There are still a few things that are personal preference, but it's mostly fine.

fix grammer

b0e1ebb

leios reviewed Jul 27, 2018

View reviewed changes

Mukundan314 and others added 3 commits July 27, 2018 10:41

Replace "an username" with "a username"

0f15fb7

Update multiplication.md

c3d1078

Update multiplication.md

e6d5c36

june128 added the Small Changes This changes a little error (regarding linking or similiar) and doesn't fit another category. label Jul 27, 2018

Butt4cak3 changed the title ~~fix grammer~~ fix grammar Jul 27, 2018

Mukundan314 added 4 commits August 8, 2018 10:46

Update cooley_tukey.md

85e7dd4

Update gaussian_elimination.md

503baf1

Merge branch 'master' into grammer

b7d71a2

Update CONTRIBUTORS.md

eec60b5

Mukundan314 and others added 2 commits September 15, 2018 17:23

Update git_and_version_control.md

a4f466c

Merge branch 'master' into grammer

1a8f857

leios approved these changes Sep 15, 2018

View reviewed changes

leios merged commit 5153e3b into algorithm-archivists:master Sep 15, 2018

Uh oh!

fix grammar #302

fix grammar #302

Uh oh!

Conversation

Mukundan314 commented Jul 27, 2018

Uh oh!

leios left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Mukundan314 Jul 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

june128 commented Sep 12, 2018

Uh oh!

leios commented Sep 12, 2018

Uh oh!

june128 commented Sep 14, 2018

Uh oh!

leios commented Sep 14, 2018

Uh oh!

june128 commented Sep 14, 2018

Uh oh!

Mukundan314 commented Sep 15, 2018

Uh oh!

leios commented Sep 15, 2018

Uh oh!

Uh oh!

Mukundan314 Jul 27, 2018 •

edited

Loading