Update C++ implementations for Verlet algorithms #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation Edit
Gathros
requested changes
Aug 6, 2018
| } | ||
|
|
||
| int main() { | ||
| double time, vel; |
There was a problem hiding this comment.
Why not just print straight to console.
There was a problem hiding this comment.
It makes the printing lines less cluttered, and it needs to be done anyway for the commands that return pairs, because I don't want to write operator<< for the pair type.
mika314
suggested changes
Aug 7, 2018
| #include <iostream> | ||
| #include <utility> | ||
|
|
||
| typedef std::pair<double, double> vpair; |
There was a problem hiding this comment.
using vpair = std::pair<double, double>;is preferable way.
There was a problem hiding this comment.
I think I would prefer a simple struct with descriptive fields over the pair anyway. std::pair is alright for utility types but I dislike it for types that should have some semantic meaning.
| } | ||
|
|
||
| int main() { | ||
| double time, vel; |
There was a problem hiding this comment.
|
|
||
| // Note that depending on the simulation, you might want to have the verlet | ||
| // loop outside. | ||
| time_vel_pair = velocity_verlet(5.0, -10, 0.01); |
| @@ -16,8 +19,7 @@ double verlet(double pos, double acc, double dt) { | |||
| return time; | |||
| } | |||
|
|
|||
| // Simple function for stormer-verlet | |||
| double stormer_verlet(double pos, double acc, double dt) { | |||
| std::pair<double, double> stormer_verlet(double pos, double acc, double dt) { | |||
| } | ||
|
|
||
| double velocity_verlet(double pos, double acc, double dt) { | ||
| std::pair<double, double> velocity_verlet(double pos, double acc, double dt) { |
mika314
approved these changes
Aug 14, 2018
Gathros
reviewed
Aug 25, 2018
| << time << std::endl; | ||
|
|
||
| timestep timestep_sv = stormer_verlet(5.0, -10, 0.01); | ||
| std::cout << "Time for Stormer Verlet integration is: " \ |
There was a problem hiding this comment.
I prefer to use an explicit line continuation indicator even when not required.
Gathros
approved these changes
Sep 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done according to #257.