Skip to content

Update Rust implementations for Verlet algorithms #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2018

Conversation

berquist
Copy link
Member

This makes the changes outlined in #257.

This is also the first Rust code I've ever written, so I don't know if it's idiomatic other than the implicit return. See here for the approach.

@Gathros Gathros added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jul 24, 2018
@Butt4cak3
Copy link
Contributor

You slipped (accidentally?) slipped some unrelated changes into this PR. I was about to approve this one, but I'll let @leios take a look at the grammar changes first.

@Gathros Gathros added the Chapter Edit This changes the archive's chapters. (md files are edited.) label Jul 24, 2018
@leios
Copy link
Member

leios commented Jul 24, 2018

The grammar changes are fine.

@Butt4cak3
Copy link
Contributor

Sorry for taking so long to get back to this. I took a break and forgot about the fact that there are still PRs open that require my attention. I will try to get this merged as soon as I get home from work today.

@Butt4cak3 Butt4cak3 self-assigned this Aug 28, 2018
@Butt4cak3
Copy link
Contributor

Alright. Took me another two days but I got around to reviewing and resolving the conflicts. Sorry for the long wait.

@Butt4cak3
Copy link
Contributor

Butt4cak3 commented Aug 30, 2018

Alright. Still trying to get back into it properly. Took me another 2 days to get back to this but I got around to reviewing this and it's ready to merge. Sorry for making you wait this long. I don't like how there are multiple things in this pull request as I personally prefer PRs to be about one thing and one thing only, but the grammar stuff got approved and the whitespace change in Julia won't break anything either.

@Butt4cak3 Butt4cak3 merged commit 36e68b7 into algorithm-archivists:master Aug 30, 2018
@berquist berquist deleted the verlet-rust branch September 22, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chapter Edit This changes the archive's chapters. (md files are edited.) Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants