-
-
Notifications
You must be signed in to change notification settings - Fork 359
Update Rust implementations for Verlet algorithms #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You slipped (accidentally?) slipped some unrelated changes into this PR. I was about to approve this one, but I'll let @leios take a look at the grammar changes first. |
The grammar changes are fine. |
Sorry for taking so long to get back to this. I took a break and forgot about the fact that there are still PRs open that require my attention. I will try to get this merged as soon as I get home from work today. |
Alright. Took me another two days but I got around to reviewing and resolving the conflicts. Sorry for the long wait. |
Alright. Still trying to get back into it properly. Took me another 2 days to get back to this but I got around to reviewing this and it's ready to merge. Sorry for making you wait this long. I don't like how there are multiple things in this pull request as I personally prefer PRs to be about one thing and one thing only, but the grammar stuff got approved and the whitespace change in Julia won't break anything either. |
This makes the changes outlined in #257.
This is also the first Rust code I've ever written, so I don't know if it's idiomatic other than the implicit return. See here for the approach.