Adding Euclidean Algorithm in Lua #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
june128
added
the
Implementation
jiegillet
reviewed
Jul 24, 2018
| local b = math.abs(b) | ||
|
|
||
| while b ~= 0 do | ||
| local temp = b |
There was a problem hiding this comment.
I don't know Lua, but a quick search shows me that you can assign pairwise variables, so maybe a, b = b, a%b is cleaner
There was a problem hiding this comment.
Ya I definitely agree its way cleaner that way. I just made a commit to adjust my code accordingly.
jiegillet
requested changes
Jul 27, 2018
| @@ -68,6 +70,8 @@ Modern implementations, though, often use the modulus operator (%) like so | |||
| [import:17-29, lang="swift"](code/swift/euclidean_algorithm.swift) | |||
| {% sample lang="matlab" %} | |||
| [import:19-31, lang="matlab"](code/matlab/euclidean.m) | |||
| {% sample lang="lua" %} | |||
| [import:16-27, lang="lua"](code/lua/euclidean.lua) | |||
There was a problem hiding this comment.
Change the 27 to 25 and we're good to go!
There was a problem hiding this comment.
Sorry, I forgot to update the md file after the last commit. Just made a commit to fix this.
jiegillet
approved these changes
Jul 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been learning a little bit of Lua. So I figured I should add some to the AAA.