Skip to content

Implementation Edit to Verlet Integration in Java #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 8, 2018
Merged

Implementation Edit to Verlet Integration in Java #290

merged 6 commits into from
Sep 8, 2018

Conversation

Wesley-Arrington
Copy link
Contributor

@Wesley-Arrington
Fixes for Verlet in Java
1053903 
- Made compliant with #257
- put in class so it can be run without additional code
- removed comments before some functions which say the name of the function
@Gathros Gathros added the Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.) label Jul 22, 2018
@Butt4cak3
Copy link
Contributor

How about renaming verlet.java to Verlet.java while you're at it? That way one can actually run it as-is.

@Butt4cak3 Butt4cak3 mentioned this pull request Jul 22, 2018
Closed
7 tasks
@Wesley-Arrington
Copy link
Contributor Author

Nice catch, just made that change.

zsparal
zsparal suggested changes Aug 9, 2018
View reviewed changes
contents/verlet_integration/code/java/Verlet.java Outdated
return time;
}

static double[] stormer_verlet(double pos, double acc, double dt) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue that returning a named class here would be much more elegant

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the suggestion and I agree. I just made a commit to return a class instead of double[]

@Wesley-Arrington
Returning Class instead of double[]
806af7b 
- Created VerletValues Class
- Changed where double[] was returned to VerletValues
- Updated .md with new code cutoffs
@Wesley-Arrington
Fixing Whitespace
9447fbe
@Wesley-Arrington
Copy link
Contributor Author

Wesley-Arrington commented Sep 7, 2018 •
edited
Loading

Hi, I just wanted to check in on the state of this PR :)

Are there any changes I should make?

@june128
Copy link
Member

june128 commented Sep 7, 2018

Hmm, apparently the PR is approved, but not merged. Is there a reason for that @Gustorn ?

@Gathros
Copy link
Contributor

Gathros commented Sep 8, 2018

I've checked it and it looks fine.

@Gathros Gathros merged commit 471fd95 into algorithm-archivists:master Sep 8, 2018
@Wesley-Arrington Wesley-Arrington deleted the javaVerlet branch September 10, 2018 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsparal zsparal zsparal approved these changes

Assignees
No one assigned
Labels
Implementation Edit This provides an edit to an algorithm implementation. (Code and maybe md files are edited.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Wesley-Arrington @Butt4cak3 @june128 @Gathros @zsparal