Thomas algorithm in java #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation
june128
reviewed
Jul 21, 2018
| @@ -44,6 +44,9 @@ $$ | |||
| [import, lang:"c_cpp"](code/c/thomas.c) | |||
| {% sample lang="py" %} | |||
| [import, lang:"python"](code/python/thomas.py) | |||
| {% sample lang="java" %} | |||
| [import, lang:"java"](code/java/thomas.java) | |||
|
|
|||
There was a problem hiding this comment.
Someone, who can review Java, will look at the actual code in the following hours/days.
I just noticed this extra redundant line tho.
|
Perfect, now we just have to wait for the actual review :) |
PudottaPommin
previously approved these changes
Aug 6, 2018
There was a problem hiding this comment.
Seems pretty straightforward like example in C.
I have no objections, nice work :)
ping @leios
leios
approved these changes
Aug 6, 2018
|
Thanks @MichalHanajik for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.