Skip to content

Added a note in README.md for new contributors #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

Butt4cak3
Copy link
Contributor

@Butt4cak3 Butt4cak3 commented Jul 19, 2018

We're receiving an increasing number of PRs of people trying to submit entirely new chapters. Even though @leios decided that he would allow some people to write new chapters, it's not an entirely open-to-the-public process yet.

This PR adds a very visible note right at the top of the README.md file in the root of this repository. I think a note like this is long overdue. New contributors cannot know the current situation when it comes to chapter contributions. With this note, we can at least point to something when we close such PRs.

@leios
Copy link
Member

leios commented Jul 19, 2018

Yeah, this is a good idea. As a note, the following statement is already in the How to Contribute page: "At this point, I am trying to figure out the best way to balance community contributions and text. Right now, I feel comfortable writing the text associated with each algorithm and asking for the community to write individual implementations. In the future, I might allow other users to write algorithm chapters, but for now let's keep it simple: I'll do the writing, everyone else does the coding."

I thought that would be enough. I'll allow chapter submissions if people talk to me about it first.

@Butt4cak3
Copy link
Contributor Author

@leios The thing is that it's just not visible enough in my opinion. Otherwise we wouldn't have this number of chapter pull requests right now. But if this doesn't help, then I don't know what does.

Copy link
Member

@leios leios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fair warning. I think it should be accepted.

@leios leios merged commit bef36fa into master Jul 19, 2018
@Butt4cak3
Copy link
Contributor Author

We can always remove it when we feel it's not necessary anymore.

@Butt4cak3 Butt4cak3 deleted the chapter-contribution-note branch July 21, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants