Reimplemented Verlet Integration in Python #256
Conversation
| self.acc = acc | ||
| while pos > 0: | ||
| time += dt | ||
| prev_pos, pos = pos, pos * 2 - prev_pos + acc * dt * dt |
There was a problem hiding this comment.
I don't know about this one. I thought about changing it to the following, but I wasn't sure, so feel free to tell me your opinion.
next_pos = pos * 2 - prev_pos + acc * dt * dt
prev_pos, pos = pos, next_pos
There was a problem hiding this comment.
Your method is definitely easier to read.
There was a problem hiding this comment.
They're both my methods. I just wasn't sure which one to use. Which one do you mean?
| print("Time: {:.10f}".format(time)) | ||
| print() | ||
|
|
||
| time, vel = stormer_verlet(5, -10, 0.01) |
There was a problem hiding this comment.
I think other methods just return time?
There was a problem hiding this comment.
That's correct. I thought that if I already have the vel variable, I might as well do something with it. Especially in stormer_verlet in Julia, the vel variable is assigned a value but it is never actually used anywhere.
But I can get it in line with everything else. I probably should, since I was talking about bringing language implementations closer to each other.
There was a problem hiding this comment.
Ah, you are right. The stormer-verlet is basically just verlet with a velocity term. Maybe we should output it?
There was a problem hiding this comment.
I mean... My answer to that is in the code =P
There was a problem hiding this comment.
Yeah, leave it. I think it's fine and an improvement.
Gathros
added
the
Implementation Edit
|
Gosh, imagine that, conflicts caused by files being moved around. @Butt4cak3, can you fix these? |
|
Done. |
During a recent discussion about #243 I noticed that the Python version of our Verlet Integration example code is vastly different from all other implementations. It creates a
Simulationclass and the 3 Verlet algorithms are classes that inherit from thatSimulationclass.I changed the code to more closely match the other language implementations because I think that introducing classes and inheritance to a piece of example code like this is a bit excessive. Tell me what you think.