Changes to Euclidean Algorithm in Java #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gathros
added
the
Implementation Edit
|
I agree. These are code examples, not libraries, so it's alright to put everything into one file/class. I'll wait another day or two and then merge it if nobody has a good reason not to. |
... or four. |
Butt4cak3
approved these changes
Jul 15, 2018
|
haha its all good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the Euclidean Algorithm should be implemented and run within a single class rather than two. So I modified the implementation of the Euclidean Algorithm in Java to only be one class. I made the following changes:
This may just be a personal preference though so I understand if it isn't merged 👍